Fuxing Loh

Results 148 comments of Fuxing Loh

> Will do some local testing of this PR to see how this works before approving, looks neat! If this works flawlessly, we need to update typescript to 4.5 and...

The genesis of this problem is linked to https://github.com/DeFiCh/jellyfish/issues/274 https://github.com/DeFiCh/jellyfish/blob/63fd7700ef9959cc50bb2dadfc3cff202771aaab/packages/jellyfish-transaction-builder/__tests__/provider.mock.ts#L45-L48 Because of certain unknown internal wiring (defid), it's very difficult to "chain requests" as we can't easily list transactions due...

/apps whale-api /area apps /kind question The 2 APIs are created by different indexers for different reasons. https://github.com/JellyfishSDK/jellyfish/blob/ed81791462c24299029255dd62d22fae658d92e2/apps/whale-api/src/module.model/transaction.vin.ts#L51 Currently, it's sorted in lexicographic order (as above), which is required within...

Since this is an Open Source project, contributions are much appreciated! The different services developed thus far are implemented and tested by various stakeholders within the ecosystem for their specific...

/kind feature /apps whale-api Hmm, that's a good point. Previously; the decision to forcefully set certain APIs to max 30 was to prevent abuse. I don't have a clear solution...

For the `ValidationPipe` I think we should also add `forbidUnknownValues: true`, I remember reading somewhere it's best if we enable it. But can't seem to find the issue talking about...

Working on `blockchain.cpp` 1. getblockchaininfo

Will be working on various `rawtransaction.cpp` rpc for wallet integration. 1. getrawtransaction 1. createrawtransaction 1. decoderawtransaction 1. decodescript 1. sendrawtransaction 1. combinerawtransaction 1. signrawtransactionwithkey