jellyfishsdk
jellyfishsdk copied to clipboard
BirthdayResearch
Make max query size configurable
Hi
Currently max query size is hardcoded to 30 in this case or 200 in others. Can we make this configurable i.e through ENV vars? I understand this is useful for Ocean but if you want to host whale yourself it would be nice to increase the size.
https://github.com/JellyfishSDK/jellyfish/blob/7436e489ca857bd814804c3ce57c38b68a10193d/apps/whale-api/src/module.api/loan.vault.service.ts#L46
@sancag: Thanks for opening an issue, it is currently awaiting triage.
The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.
Details
I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.
@sancag: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!
You can add area labels by leaving a /area comment.
Details
I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.
/kind feature /apps whale-api
Hmm, that's a good point. Previously; the decision to forcefully set certain APIs to max 30 was to prevent abuse.
I don't have a clear solution towards making this simple without creating much complexity yet. There is an option to remove it entirely, but perhaps it would be better if we can unify it and use nestjs annotation validator?
