Results 264 comments of Fu Wei

Hi @jokemanfire , would you please file pull request to fix this? thanks

Sound good to me! Especially, it can help us to do sanity and compatible check on mix-versions cluster.

Closing because it looks like bot reply. Please feel free to reopen it if it is mistake.

@Ben131-Go Thanks for the comment. I reopen it and fix it later.

I think you should do daemon-reload first and then restart containerd. And it only makes sure that it works for new containers, not for existing ones.

``` === FAIL: integration/client TestContainerPTY (5.99s) container_test.go:2741: output `` does not contain \x00, trying again container_test.go:2741: output `` does not contain \x00, trying again container_test.go:2739: expected \x00 in output ```...

@jeromegn Will take a look today. Thanks for reporting

@jeromegn could you mind to share more log before this line `time="2020-12-08T12:20:48.474220424Z" level=debug msg="prepare snapshot`? I was thinking it is something wrong at the devmapper backend data? And if possible,...

Thanks! @jeromegn One more question, you are using different disk for containerd storage? I had that issue before in https://github.com/containerd/containerd/issues/3671#issuecomment-539974858. Hope it can help.

It seems that if TTY is disable, containerd-shim will create pipe and pass through writable fd to runc. And then init process inherits the writable fd as stderr or stdout....