runc icon indicating copy to clipboard operation
runc copied to clipboard

Failed to set property TasksAccounting when using systemd as cgroup driver

Open jfbai opened this issue 6 years ago • 2 comments

Version

systemd version: 219-30.el7_3.9 kubernetes version: v1.14.4 CentOS: 7.2

What happens

kubelet failed to start with errors

Apr 19 11:20:09 kubelet[20002]: E0419 11:20:09.770078   20002 node_container_manager_linux.go:50] Failed to create ["kubepods"] cgroup
Apr 19 11:20:09 kubelet[20002]: F0419 11:20:09.770102   20002 kubelet.go:1359] Failed to start ContainerManager Cannot set property TasksAccounting, or unknown property.

In my case, the TasksAccounting is a read only property.

What expected

kubelet should start successfully even if TasksAccounting and TasksMaxs properties are not supported.

Other notes

TasksAccounting and TasksMaxs were introduced in systemd 227, and in CentOS systemd, it seems that these two properties are added after 219-30.el7_3.9. So, I'd like to know if it would be better to report warning instead of exit with error when TasksAccounting and TasksMaxs are not supported or readOnly.

jfbai avatar Aug 02 '19 03:08 jfbai

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar May 14 '25 13:05 k8s-ci-robot

/cc @fuweid @thaJeztah since you guys contributed some of these code and may have more context on them. I think we should be good to delete them given we have go 1.24.3 as the min version?

djdongjin avatar May 28 '25 16:05 djdongjin

=== FAIL: integration/client TestContainerPTY (5.99s)
    container_test.go:2741: output `` does not contain \x00, trying again
    container_test.go:2741: output `` does not contain \x00, trying again
    container_test.go:2739: expected \x00 in output

hmm this issue shows up again

fuweid avatar Jun 10 '25 02:06 fuweid

@fuweid @estesp can you help add this one to merge queue again? thanks 🙏

djdongjin avatar Jul 06 '25 18:07 djdongjin