Evan Niessen-Derry
Evan Niessen-Derry
Hey @sshaw, I'll admit that I'm totally ignorant about global state (and emacs hacking in general), so I don't really have a good answer for this. I'll say that the...
Thinking about this more, @sshaw is your question about whether `git-link-url` can be called as a pure function, versus _needing_ to be called inside the buffer you want the link...
I'll see if I can shake that out today.
While I sort this out, @sshaw, I've noticed that `git-link` works in the same way as my change -- my change is just to extract some functionality from `git-link` --...
@sshaw after reviewing more of the code, I think I'm starting to see the way this could work. One question: what's the goal of the optional arg `use-branch`?
> That is supposed to be the equivalent of sorts of git-link-use-commit. Rockin, that makes sense. Another question! You'd put the remote as an optional argument, but the function can't...
Ok @sshaw, this should be ready. I went ahead with making `remote` a required argument, but let me know if I missed something and it should be optional.
J/k, sorry. I need to fix a void-variable reference. Will ping you once it's solid.
Ok, tested, and should be good to go for review @sshaw.
Hey @sshaw, thanks for the suggestions on `user-error`! I've never done error signaling/handling in elisp, so that was a fun excursion. I've just pushed up that change, and it should...