FUTATSUKI Yasuhito

Results 99 comments of FUTATSUKI Yasuhito

In develop branch, the variable name `pct` has been changed to `signpct` but it contains same logic. Also I could confirm that it causes "SIGFPE, Arithmetic exception. Integer divide by...

With the patch on PR #223, I could confirm the case I tried above does not cause exception.

I didn't tried it in opendkim.conf actually, but it uses strcasecmp() for checking directives in opendkim/config.c, so I guess it is case insensitive.

Per [RFC8601 Sec 2.7.1.](https://www.rfc-editor.org/rfc/rfc8601#section-2.7.1), it seems that we should use dkim=policy in such a case, rather than excluding from AR header.

With this change, with old postfix (2.10) and old libmilter (8.14.7), opendmarc milter cannot get AR headers added by opendkim. However after rebuilding opendkim and opendmarc with libmilter 8.18.1, even...

> However after rebuilding opendkim and opendmarc with libmilter 8.18.1, even appy this PR patch, opendmarc can get AR headers. This was incorrect, even with libmilter bundled in sendmail-8.18.1, our...

> in neither case did opendkim crash. Furthermore, you can solve a lot of these issues with db table constraints. I'll take a look later, if it can avoid crash...

> also should there be a command line option for it ? example, ` opendkim/opendkim.c:15594: /* process command line options */` if yes, which letter may I use ? Currently...

> can we consider the long options issue as a separate issue? one commit at a time so we dont get overloaded. ya, sorry, I think it is a separate...

This feature may useful even if ODBX feature is not used, so I think it is not need to restrict it on USE_ODBX is true. No other things to say,...