FUTATSUKI Yasuhito

Results 100 comments of FUTATSUKI Yasuhito

The order should be opendkim -> opendmarc (because it depends on AR from opendkim) -> openarc(for AAR, depends on AR from opendkim and AR from opendmarc). However the order described...

As far as I read RFC 2047 and RFC 6376, as a body field of `DKIM-Signature:` header is not defined as '`*text`' and does not contain any `phrase` , `encoded-word`...

> ...Do you think we have much chance convincing Apple, Oracle, IBM, Meta to change their ways? Probably no in directly, but it is enough to reject mails like those...

According to [RFC 5322 section 2.1.1.](https://www.rfc-editor.org/rfc/rfc5322#section-2.1.1) each line of characters MUST be no more than 998 characters, and from the description about field name [section 2.2.](https://www.rfc-editor.org/rfc/rfc5322#section2.2) filed names cannot be...

Even if the issue is resolved by applying this PR, I don't think the cause of the issue is the value of BUFRSZ, but the wrong size estimation of (a)...

As far as I read the code of OpenDMARC, how it uses the AAR header information, even if it would not ignore the AAR header added by OpenDKIM + OpenARC,...

If the signature did not specified header canonicalization algorithm or specified the "simple" canonicalization algorithm, such transformations of the header done by MTAs cause verification faulure ([RFC 6376 section 3.4.1](https://www.rfc-editor.org/rfc/rfc6376.html#section-3.4.1))....

> Maybe (rfc 5322, s 2.2.3) assumes that a long header includes higher level syntactic elements, including comma separated lists, and that comma separated lists has spaces as well as...

@flowerysong Thank you for the review. I agree that `arc_getseal()` in libopenarc/arc.c should be fix, because the function already awares that the argment `ar` may be NULL pointer, and processes...

> Althouh I've not yet tested your commit, it looks good to me. I've check it later. I've checked with https://github.com/flowerysong/OpenARC/commit/9dc8658366b9b3cadbed09754fdf1a7e5cd61e47 without ef5a6d046052fd8807f72b476d50e053b6b74dfc. It works fine as we expected. So...