paramak

paramak copied to clipboard

Workplane is not subscriptable error when rotation cadquery.Plane

1

It is possible to set the workplane to a string such as 'XY' or 'ZY' It is also possible to set the workplane to an arbitrary plane using a cadquery.Plane...

shimwell

Full rotation shapes cause problems with cubit and openmc

3

Let me first congratulate the authors for this fantastic project and the related repos that I really came to appreciate in the past days. **About the problem** When creating shapes...

cbaus

argument type hinting for filenames

1

filenames arguments are strings throughtout the code. Perhaps a ```Path``` object could also be accepted. The type hinting would need changing to ```Union[str, PathLike[str]]```

shimwell

Use @types decorator to enforce arguments types

15

I spotted this decorator below. Thanks @EmilyBourne for sharing this repo 😄 https://github.com/EmilyBourne/Pygyro/blob/02031f96f9b05c3c523290fe349eeef9e39138ba/pygyro/advection/accelerated_advection_steps.py#L21. We could make use of this decorator to enforce the arguments types. This could greatly reduce the...

RemDelaporteMathurin

When checking for types passed into functions it can be useful to ensure only positive ints or positive floats Here is an example https://stackoverflow.com/questions/61546201/python-typehint-int-as-positive Perhaps a new class called PositiveInt...

shimwell

unused import in the __init__.py

1

This is reducing the flake 8 warnings perhaps ```___all__ = [import import]``` could be used as described here https://stackoverflow.com/questions/31079047/python-pep8-class-in-init-imported-but-not-used

shimwell

This additional twine check command could check that the package builds https://github.com/C-bowman/inference-tools/blob/760061e77bdc8ddeacb951196a3deb783a6ccffd/.github/workflows/tests.yml#L48 It should be in the regular CI so that it is caught before publishing action

shimwell

Wrong argument type in utils.intersect_solid

1

https://github.com/fusion-energy/paramak/blob/bee4f0434309dd3529d320f85d2cc9a819044bc5/paramak/utils.py#L229-L246 In the code above, intersecter is a paramak.Shape but solid is paramak.Shape.solid type.

RemDelaporteMathurin

PoloidalFieldCoilSet ignores azimuth_placement_angle

1

Because PoloidalFieldCoilSet overwrites `create_solid`, the step `rotate_solid` is ignored. Hence, the azimuth_placement_angle has no influence on this shape. https://github.com/fusion-energy/paramak/blob/bee4f0434309dd3529d320f85d2cc9a819044bc5/paramak/parametric_components/poloidal_field_coil_set.py#L106-L143

RemDelaporteMathurin

for example ```BlanketConstantThicknessArcH``` has no .name set

shimwell