Marcus Furlong
Marcus Furlong
Could add #noqa for the URL line too long issues?
Cool 👍 Could you squash all commits into one, and reset to 7c2b6370be8c2f97e0a8d08607e993792876d51c ? Then submit smaller pull requests based on added functionality, bugfix per patch etc... (e.g. with `git...
git squash COMMIT `pick` the first commit and `squash` all others - this will create one big commit. git reset HEAD^1 git add -p git commit -m "fix thing" git...
Hmm, the first commit seems to contain an already merged change? And the second commit - I was hoping you could break this into smaller commits/PRs with e.g. git add...
`git add -p` should help break them out?
It looks like there are still conflicts with master. Did you try with `git add -p`? It asks you which patch lines to add to a certain commit. So if...
@ndobbs: agreed. It should be broken down into smaller commits with `git add -p` though. I'll stick it on my to-do list and see if I can do it.
I added some of these features to the master branch, but others still need to be added. This branch has conflicts with master now so it doesn't apply cleanly, and...
Can you provide the debug output as per the README?
Is the problem that you don't want the ipv6 addresses showing? It seems like these are valid ip addresses?