Kacper Obrzut

Results 7 comments of Kacper Obrzut

Regarding all discussions, I'm on a way to implement token generator functionality. It would allow removing deprecated `@azure/ms-rest-nodeauth` package from tedious (that would be a breaking change, mentioned in https://github.com/tediousjs/tedious/pull/939)....

@arthurschreiber Could you look up to my refactor changes? I'm on the way to implement a new authentication type, but first, I'd like to clean up the code. **EDIT:** For...

@arthurschreiber ready for re-review :D

Let me check that. I saw some castings, and I need to check if your proposition covers all of them. > One other thing I'm wondering - do we even...

That would allow to make the following files per authentication type: ```typescript // Contents of /src/authentication/azure-active-directory-msi-app-service.ts export const AzureActiveDirectoryMsiAppServiceType = 'azure-active-directory-msi-app-service'; export interface AzureActiveDirectoryMsiAppServiceAuthentication { type: typeof AzureActiveDirectoryMsiAppServiceType; options: {...

Finally, it would allow keeping the validation methods of each type in dedicated files instead of one huge file.

@arthurschreiber I have finished. Summarizing: 1. There is a `SupportedAuthenticationTypes` that is used for storing supported authentication types. It is a constant, as you asked. 2. I created `FedAuthAuthenticationType`, `AADAuthenticationType`,...