Haoze Wu

Results 21 comments of Haoze Wu

@Apache9 I think you have a fair point. I think the key question here is how quickly can we retry without taking high risk of greatly increasing the load of...

@jlerbsc I see. Thanks for the solution. BTW, I found that `getName()` returns a `SimpleName` object, and the class name is the `identifier` of `SimpleName`. So, what is the meaning...

I believe that in the CI server, multiple test cases fail due to the network connection binding issue, and the QuorumMainTest fails because the ZK snapshot is compromised by some...

> One thing I am wondering (which was not introduced by your code) is why we catch and continue on `SaslException`s, but "crash" on other `IOException`s? Not a major point...

> Follower can do the same. @lanicc, IMO, the root problem this issue exposes is that the exception caught by `ZooKeeperCriticalThread` is translated into the state change in zkServer. Even...

I've added `LOG.warn` when this case is happening. You can take a look @eolivelli @ztzg @lanicc Thanks for the test case you provide! It inspires me a lot. I implemented...

@maoling Sorry to bother you. But the other guys might be busy recently. Can you help review my patch & test case? And approve the CI workflow? Thank you!

@eolivelli The state check & modification within `setState` method should be atomic as a whole, so `AtomicReference` is not enough (including the `updateAndGet` methods and so on). Now I use...

@eolivelli @ztzg I'm following up on whether we will merge or improve this patch soon? Thanks!

Thanks @Hexiaoqiao for your review. I have added the multi-threaded executor for it. For the exception handling part, I observe the original semantics of `RpcEdit` https://github.com/apache/hadoop/blob/aaedc51d8783c2808563d5c8b51b68ab79e19820/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L379-L387 and `SyncEdit` https://github.com/apache/hadoop/blob/aaedc51d8783c2808563d5c8b51b68ab79e19820/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L347-L353 Therefore,...