William Entriken

Plus Codes regex is incorrect

6

In https://github.com/google/open-location-code/wiki/Supporting-plus-codes-in-your-app it is stated: > Global codes can be recognised and extracted from a query using a regular expression: However, a particular global code "15,849VGJQF+VX7QR3J" taken from the [test...

When creating test cases, it is best practice to NOT compare floating point values using an equality check. Therefore, test cases like these are inappropriate: https://github.com/google/open-location-code/blob/master/test_data/decoding.csv#L26 Or, there should be...

There is an acceptance test suite at https://github.com/google/open-location-code/tree/master/test_data Every implementation should use exactly those test cases. This means that improvements to the test cases will benefit every implementation.

Create a project scope

2

Creating a scope to define what contributions this project is looking to accept will help the community to close other issue. Here is an example of something I think is...

Package.json release version does not match GitHub release version

4

On GitHub, the latest release is version 1.0.4 https://github.com/google/open-location-code/releases/tag/1.0.4 But the package file shows the latest release as 1.0.0 https://github.com/google/open-location-code/blob/master/package.json

CPP implementation: does not reference a required separator character

2

The C++ implementation states: > // Returns an Open Location Code with code_length significant digits. The string > // returned may be one character longer if it includes a separator...

By default, please ask people for their GitHub repo URL and add a "Edit This Page on GitHub button" to all generated pages. This will be a huge benefit to...

Switching scenes too fast messes up fading

3

### Operating System Info macOS 12 ### Other OS _No response_ ### OBS Studio Version 27.2.4 ### OBS Studio Version (Other) _No response_ ### OBS Studio Log URL n/a ###...

修改 #126

mp4 double extension

1

When attempting to download video, if the XML response is including a file such as abcd.mp4, then the program is attempting the url abcd.mp4.mp4.