Tomoya Fujita

Results 1307 comments of Tomoya Fujita

@iuhilnehc-ynos can you review this?

@ahcorde thanks for the ping. since this is 1 year old, i gotta say i need to refresh my memory including background. let me have some time and get back...

> to have outside applications or folks listing the directory easily understand the situation I think .active is nicer. IMO, i second this with renaming the file without creating extra...

> IMO the new work related to this issue shall be done above https://github.com/ros2/rosbag2/pull/1643 anyway. 👍 agree, and thanks for sharing insights! all that said, i think the completion event...

IMO we could have `rosbag2_examples_::SimpleBagPlayer` and https://docs.ros.org/en/rolling/Tutorials/Advanced/Reading-From-A-Bag-File-CPP.html link it as an example. This seems `good-first-issue`, probably we can tag this issue with `help-wanted`? 😄

@MichaelOrlov thanks for checking this, i will take a look at this today.

that works for me with `rolling` https://github.com/ros2/ros2/commit/4d07f58591920794676261a14c2ba9d0a7bf2746 i think you are missing some required packages (Qt), and that leads https://github.com/python-pillow/Pillow/blob/f8160b858aebf8b7bffdefba48735feac300a060/src/PIL/ImageQt.py#L172 this if statement to be false? there are no platform...

@jhrncar thanks for posting issue. there has been discussion related to `rclpy` (python client library) performance before, it would be really nice to have the performance improvement but i do...

thank you for sharing thoughts. IMO, if i work on embedded system, i would not even use shell script, instead compile them into executables to keep the performance. (python would...

i do not think it has to be exclusive, i am happy to review. but adding like `rclpy is slower than rclcpp` would generate other questions, `what is the appropriate...