Frank Thomas

Results 290 comments of Frank Thomas

> I just transferred the repo to the organization. Thanks! > It's still called `mill-scala-steward`, as I don't have the permissions to rename it. You are now admin of this...

I think the reason for this bug could be [this line](https://github.com/lucidsoftware/neo-sbt-scalafmt/blob/7321eeddbf52f2a9e3ffa44e061eebeb3d1febb4/sbt-scalafmt/src/main/scala/com/lucidchart/sbt/scalafmt/ScalafmtCorePlugin.scala#L199): ```scala sourceDirectories := Seq(scalaSource.value) ``` The plugin should pick up all source directories if this is changed to `sourceDirectories...

It looks like Scala Steward ran [code for Mill < 0.11](https://github.com/scala-steward-org/scala-steward/blob/v0.28.0/modules/core/src/main/scala/org/scalasteward/core/buildtool/mill/MillAlg.scala#L48-L55) to extract dependencies. Does the zhutmost/chipmunk repo has a `.mill-version` and does it contain a version `>= 0.11`?

Sounds like a `.mill-version` with a 0.11 version would fix this issue then.

If you add `.mill-version` with a 0.11 version, it will run this [code](https://github.com/scala-steward-org/scala-steward/blob/v0.28.0/modules/core/src/main/scala/org/scalasteward/core/buildtool/mill/MillAlg.scala#L44-L47).

> It'd be nice to have a config option to tell scala-steward not to open the PR at all, if migrations fail. Sounds good to me. We could just throw...

> Is there a way to prevent _all_ major upgrades by Scala Steward? Any workaround? Nothing I'm aware of. > Maybe a pointer for adding this? Maybe we can tweak...

You could try adding `updatePullRequests = "always"` to `.github/.scala-steward.conf` and run Scala Steward again. Maybe it will update the old PR with your new configuration.

As I understand it, Gradle is a popular choice for Kotlin projects and that would allow Scala Steward to also keep those Kotlin projects up-to-date.

https://github.com/gradle/gradle/issues/21894 is interesting in this context and would allow Scala Steward to easily extract dependencies from Gradle builds.