Frank Thomas

Results 290 comments of Frank Thomas

> I'm a little confused about which part is expensive. Checking every open update PR for new comments. It would be ideal if we could determine with just one API...

> I'm happy to open a separate issue to discuss that if it makes more sense, since it's admittedly not what the OP asked for. Sounds good to me. I...

> My understanding is this: > > 1. when going over an update, if a PR is already open, scala-steward check if the base branch has been updated Correct: https://github.com/scala-steward-org/scala-steward/blob/v0.24.0/modules/core/src/main/scala/org/scalasteward/core/nurture/NurtureAlg.scala#L277...

> Apart from that this sounds like an awesome idea I agree. Maybe this should then be the default method of updating PRs. I guess most people do not mind...

> If Scala Stewart force-pushes to its update PRs, please consider using `git push --force-with-lease` instead of `git push --force` in order to avoid losing any manual updates made by...

IMO we could just replace the current revert-and-apply strategy with the new reset-and-apply-and-force-push strategy. I don't think anyone would miss the current strategy and we wouldn't have to change the...

Further discussion about changing the method how update branches are updated (which started with https://github.com/scala-steward-org/scala-steward/issues/1761#issuecomment-1584014610) should happen in https://github.com/scala-steward-org/scala-steward/issues/3218.

WIP PR for Gitea support: https://github.com/scala-steward-org/scala-steward/pull/2758

Closing since this is an issue with the used JDK version and the repo Scala Steward is working on but not an issue with Scala Steward itself.

I don't maintain an instance that works with GitHub anymore, but still have logs of @scala-steward from March and April 2022. I looked at four occasions where it hit the...