Frederic Tessier

Results 161 comments of Frederic Tessier

Rebased @ellieb's branch on the EGSnrc repo develop branch. Moved the code to HEN_HOUSE/gui/dose-viewer

Nope, we want the code to be in the repository for source control; We don't want to duplicate source management, pull requests, etc., on an orphan branch; even though as...

@rtownson I take that back, I see now that we _could_ maintain the web dose viewer code on the orphan `gh-pages` branch, and create the pull requests against that branch...

Ok, well it seems that hosting with github pages remains the best option here. We can also now host a separate repo for `egsnrc.github.io` (instead of a separate _branch_), which...

@ellieb I am considering using JS `standard` (https://standardjs.com/) to lint and format the `.js` files in your pull request to format the code consistently, beyond personnal coding style. This avoids...

@ellieb There are only 41 remaining linting instances that seem to require some attention... At any rate, I will look into those after cleaning and squashing the branch, an consult...

And I suggest we use `prettier` to lint html code (https://prettier.io/). Other suggestions welcome!

@ellieb I have reduced this pull request to 78 commits, squashing together some smaller, related commits. I think the resulting chain of commits makes logical sense. Please take a look...

@ellieb can you review the following log from the JS `standard` linter, and let me know if any one of these suggested fixes should _**not**_ be implemented? [standard.log](https://github.com/nrc-cnrc/EGSnrc/files/5214308/standard.log)

I am pushing that to Release 2022, and I suggest that we include it as a submodule.