Filip Stanis

Results 21 comments of Filip Stanis

> `FileInfo` is just a metadata container, why would it need to be an interface? For example, for Google Drive it's convenient to keep additional information, such as an ID....

Hi all, I think there may be some confusion about what the initial "checked" 2-star state is supposed to represent in this example: the idea is that this is what...

Probably best to wait for [#17038](https://github.com/ampproject/amphtml/issues/17038) and [#17039](https://github.com/ampproject/amphtml/issues/17039) to be closed before we proceed.

Any update? It seems to fail with Open Sans regular as well now.

This might be fixable by simply specifying `minifyJs: { quote_style: 1 }`. I can't currently test, but writing this if someone else has some time.

> Does *posthtml-uglify* take into account external styles? No, it [only looks at `` tags](https://github.com/Rebelmail/posthtml-uglify/blob/fbf7a4ebf40481f092c060670ac8a5574421f05f/lib/plugin.js#L145-L154). > If not then we should do that on our side. How would that work?...

Ouch, completely forgot that this will break external stylesheets. That's a tricky problem to solve. > Disable minification at all if external CSS is found. This seems like a good...

I think a validator warning makes sense for starters. I'll see if we can reach out to existing ESPs to verify if they may be adding this tag inadvertently.

> If we have email with link to web version? Could you clarify more about this? I don't think emails in AMP format (i.e. ``) should ever be used on...

Understood, in that case, email providers should use the email subject as the title, rather than the title provided, otherwise we'd have inconsistency both with HTML emails and with how...