Fabian Braun

Results 457 comments of Fabian Braun

@fallenflint I think this has been fixed a while ago. Can this issue be closed?

Good idea! Once we're touching `ReadOnlyPasswordHashField` I'd also like to change the formatting that the button always will be on the right. Depending on viewport width, the button will otherwise...

@nessita I've rebased and rewritten to reflect your first comment: * Help texts do not contain markup or buttons * Widget now contains the button for the link * In...

@nessita Thank you for your comments! I added a bullet point to the release notes. I searched the docs and did not find a reference to the link. Have I...

Building docs fails apparently since it cannot locate the class `django.contrib.auth.forms.ReadOnlyPasswordHashWidget `. I am not sure why. What am I missing?

@ngnpope Thank you for the suggestions! Let me briefly comment and ask one more question: * Probably we do not need to wait for `DOMContentLoaded` since the script is loaded...

One more thing to add: I did use `function () { ... }` instead of `() => { ... }` since otherwise `this` is not defined properly.

@shangxiao Thanks very much for the comments: * The jumping can be stopped by putting the warning below the checkbox and above the submit button * Thanks for pointing out...

Thanks, everybody, for the constructive feedback. I have updated the PR: * @knyghty The help text now reads _Upon submission an unusable password will be set which prevents the user...