Fredrik Sandhei comments

Results 13 comments of


                                            Fredrik Sandhei

Add conversion from/to std::optional

Is there any updates on this?

Add conversion from/to std::optional

If I may ask, what is the current blocker for this to go in to the library? I see that the issues with overload resolutions taken up by @karzhenkov seem...

Change `operator==` overload that constrains to `is_scalar_v` to constrain to compatible types.

> Can you please try to amalgamate with an older version of astyle, like astyle 3.2? There was a breaking change in astyle which makes the output differ unfortunately. Sure,...

Change `operator==` overload that constrains to `is_scalar_v` to constrain to compatible types.

First, sorry, @nlohmann, for the trouble I'm causing here. So, I tried amalgamating again. There seems to be some issues or inconsistencies with the astyle version 3.2.1 from the AUR...

Change `operator==` overload that constrains to `is_scalar_v` to constrain to compatible types.

Thank you for so quick response. The amalgamation seems happy now.

Change `operator==` overload that constrains to `is_scalar_v` to constrain to compatible types.

I see that the GCC 10 CI run failed. It seems to be not able to parse the concept, which is odd as it [should be supported in GCC 10](https://en.cppreference.com/w/cpp/compiler_support/20)....

Change `operator==` overload that constrains to `is_scalar_v` to constrain to compatible types.

I'm not really sure what is Codacy is actually complaining about. The struct member is being used in the type trait. It might be a bug in Codacy. Do you...

gcc13.2 compile fail when using std::string to compare the json object

Without having worked on the library details I cannot give good rationales, but I decided to try out changing the constraint so `operator==` is called for the compatible types, like...

feat: Rebase `feature/optional` to `develop`

Changed the base branch to `develop`. I'm sorry if I'm making it a bit difficult here; I forked the repository and rebased `feature/optional` to `develop` and created this PR against...

feat: Rebase `feature/optional` to `develop`

See that clang-tidy is failing on some checks. Apparently this is on develop, too. I see that it is related to a supposed new check from clang-tidy v19: https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-designated-initializers.html.