Yulong Wang

Results 218 comments of Yulong Wang

It doesn't work because the ASM_CONSTS table (and other build time generated things) may be different for each build. There is a step that using `wasm-opt` to strip the unused...

> > It doesn't work because the ASM_CONSTS table (and other build time generated things) may be different for each build. There is a step that using `wasm-opt` to strip...

> Could you use conditional package exports? > > * https://nodejs.org/api/packages.html#conditional-exports > * https://webpack.js.org/guides/package-exports/ I already uses this. The problem is I cannot have 2 different JS files (ESM/UMD) for...

> Yes that is what I mean. Sharing a single wasm file between different JS files built with different settings is not supported, so as a fallback I think can...

> The problem is that, as you have found, any emscripten command line flag changing can result in the different wasm binary. Building a single wasm along with N different...

> And just do confirm, as far as you are aware there is no way to satisfy both ESM and UDM requirements in the single JS file? > > I...

> there is no way to satisfy both ESM and UDM requirements in the single JS file There is no way. `import`/`export` statement and `import.meta` are syntax error for UMD....

With all the discussions above, I created #20816, which tries to make an API update for `executionProviders` for WebNN. Please help to review the change.

> @fs-eire given that the API changes have landed ( #20816 ) should I modify this PR to use the new API directly or should I convert the code back...

> ONNX doesn't work. ONNX javascript does not support all the functions of PyTorch, and, most importantly, it does not support some custom functions using in the PyTorch model. And...