Fabian Ruffy

> So, I disabled PCHs by default for now. Looks like there are some tradeoffs wrt ccache, so one needs to decide what might be preferable. > > Alternatively, we...

Is the invocation of these functions somewhere on the critical path for the compiler?

@snapdgn Could you rebase this now that #4845 is merged?

@vlstill @asl Please refresh your current reviews on this PR.

I would also recommend adding an option toP4 to toggle whether to add comments etc. This way you do not conflict with the current reference files in the compiler.

> @jafingerhut Thanks for your review comments! > > I have done the test data updates a few times in the past, but it's been a while that I forgot...

The tests in this folder are quite particular. They are intended to be compiled with the eBPF PSA compiler. https://github.com/p4lang/p4c/blob/main/backends/ebpf/psa/README.md The generic eBPF tests can be found in https://github.com/p4lang/p4c/tree/main/testdata/p4_16_samples and...

> I worked on the solution provided , as the tests are carried out in an isolated environment is there any way that it could be done in SmartNIC particularly...

Closing for inactivity.

This warrants a P4-language spec group discussion.