Fabian Ruffy

@vbnogueira lmk when you want this merged.

Is this ready for review or does this depend on #5011?

Ideally this should be rebased on #5011 so that we can actually run the tests. What is also missing is the test harness (P4Tests.cmake and TestTemplate.cmake) which run the tests....

@vbnogueira Now we should we able to run this with the test framework you have added to p4tc, right?

The compiler should never throw an exception like `Compiler Bug:` to a user. This is a problem with the compiler regardless whether this is valid P4 or not.

> Tofino failures are due to inclusion of two C files into a C++ project / library (without proper language specification in the CMake `project`): > > ``` > bf-utils/src/dynamic_hash/dynamic_hash.c...

> Does anyone remember why this was needed? Is it still needed? @fruffy Iirc if you do not enable this on clang this will cause linking issues with protobuf. I...

> > Iirc if you do not enable this on clang this will cause linking issues with protobuf. I haven't found a better solution than enabling it for all CMake...

> @fruffy clang bug wrt `__builtin_bit_cast` and PCH: [llvm/llvm-project@95d7ccb](https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b) > > It seems to be fixed in clang 11. The CI is using very old clang 10. Is it possible...

Alternatively maybe we can simply patch Abseil for this version?