Francisco Rojas comments

Results 7 comments of


                                            Francisco Rojas

[Question] should Train let you modify a request inside an Interceptor?

Thank you!. Feel free to close this issue if you want 😄

[Question] should Train let you modify a request inside an Interceptor?

I think this thread is relevant https://groups.google.com/forum/#!searchin/golang- nuts/RoundTripper%7Csort:relevance/golang-nuts/U4FPkQKcAzM/xPireKYNvowJ

Make AwsSqsJobHandlerSubscriptionService public...

I would rather expose an interface that has less implementation details. Happy to pair to unblock this.

Rename `UnauthenticatedException` -> `UnauthorizedException` and `UnauthorizedException` -> `ForbiddenException`

These names are higher-level concepts meant to describe action exceptions independently of the protocols used to be transmitted (e.g., HTTP and gRPC) gRPC uses [UNAUTHENTICATED](https://grpc.github.io/grpc/core/md_doc_statuscodes.html) instead of the HTTP [Unauthorized](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#401)...

Rename `UnauthenticatedException` -> `UnauthorizedException` and `UnauthorizedException` -> `ForbiddenException`

The `WebActionException` includes the [grpcStatus](https://github.com/cashapp/misk/blob/master/misk-actions/src/main/kotlin/misk/exceptions/Exceptions.kt#L21-L39) as well. These fields are used by the [WebActionExceptionMapper](https://github.com/cashapp/misk/blob/master/misk/src/main/kotlin/misk/web/exceptions/WebActionExceptionMapper.kt) to know how to translate to the relevant response depending on the protocol.

Use Jedis provider instead of direct dependency

Could you add a details with the motivation of this change, please?

Populate HttpServletRequest.servletPath with pathPattern

Could you expand on when you ran into this issues? looking at the docs it seems this method [leaks some of the implementation details](https://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getServletPath()) and I want to make sure...