David M. Rogers

Results 44 comments of David M. Rogers

I have been using spack, but I will look into CPM. On Mon, Mar 28, 2022, 10:25 PM Mark Harris ***@***.***> wrote: > ***@***.**** commented on this pull request. >...

So, getting it to work with [CPM](https://github.com/cpm-cmake/CPM.cmake#adding-cpm) required working out some namespace and code inclusion issues for downstream packages. Before, the `Hemi::hemi` target was placed inside `Config.cmake.in` so that it...

CPM's installation instructions say to `include(cmake/CPM.cmake)` - which assumes you're following CPM's regular install path (copying CPM.cmake from their repo). All their [examples](https://github.com/cpm-cmake/CPM.cmake/tree/master/examples) assume the package is structured that way.

I added your download code to `examples/blackscholes/CMakeLists.txt`. All of the examples still contain their Makefile instructions. What's added in this PR are two `CMakeLists.txt` configurations that provide optional alternatives to...

That example demonstrated CPM. But CPM won't work correctly unless you provide a tag for hemi's source tree at a revision that includes CMakeLists.txt. So you'd need a v2.0.1 tag...

This should be closed if #33 is merged.

Maybe try using the cmake setup in #33 ?

Hey, @rinkug , @bernhold , @curfman - is this one ready for publishing?

Thanks David @bernhold! I have sent a patch via email.

I'm creating a pull request that just uses the code as-is to apply the correction in the z-direction. I believe this is correct whether or not there is tilt in...