Frieder Erdmann

Results 7 comments of Frieder Erdmann

Closing this in favor of Hannes cleaned up Pull request here #23

I've started experimenting here https://github.com/friedererdmann/MaterialX/tree/extend_mix_datatypes but since this is my first contact with MaterialX' codebase, I'm very open to suggestions if I approach this correctly.

> Looks good! Thanks @friedererdmann Thanks Niklas for your review and feedback! I don't seem to be able to merge myself, will you merge the PR?

> what are the issues you have? In latest Master a number of things don't work at the moment :( The demo scripts are mixing Qt, PySide2 and PyQt5 imports,...

Hey @munkybutt - this is great! I attempted something similar in one of the branches, but didn't get around yet to make it functional. I like your approach here and...

Already decreased memory and time by moving from creating a new object per property to analyzing all properties of one class from the same object in 85a161c5c2a33be2b39470c7b12f5cb21b8e9b34. Still need to...

Actually found a work around by making one final overload: ```python @overload def example(parameter: Literal["int", "bool", "str"]): ... ```