Fridolín Pokorný

Results 197 comments of Fridolín Pokorný

Built wheel files in a fork if you would like to reuse them: https://pypi.org/project/thoth-ssdeep/#files

We use "goblinoid" successfully for some time - see https://github.com/thoth-station/goblinoid and https://pypi.org/project/goblinoid/

Hi @vlagorsse, thanks for the report. It looks like there is something fishy with config generation. Could you try keeping the generated config by supplying `--keep-config-py` and see what is...

Thanks for the review, Trishank. Comments raised were addressed. Please see also additional changes outside of the PR review comments (starting from d6731dc). A concern I have is the listing...

> Thanks, @fridex! If not too much to ask, do you think we could do some sort of integration testing against the Datadog Agent Integrations and/or Sigstore TUF metadata? These...

> > Also, for completeness, should we include a schema for mirrors.json? > > Sorry, no need for mirrors, which is being replaced by [TAP 4](https://github.com/theupdateframework/taps/blob/master/tap4.md). A schema for the...

> Sigstore's current TUF repository is here: https://github.com/sigstore/root-signing/tree/main/repository/repository! The schema validation passes except for `date-time` string in `expires`: ``` jsonschema.exceptions.ValidationError: '2021-12-18T13:28:12.99008-06:00' does not match '^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z$' Failed validating 'pattern' in schema['properties']['signed']['properties']['expires']:...

> Well done, Fridolin, I can't think of any more complaints! 🎉 Thanks for your patience and thorough review, Trishank 👍🏻

Note: ``` ll /etc/mtab lrwxrwxrwx. 1 root root 19 jan 21 20:00 /etc/mtab -> ../proc/self/mounts ``` Currently there is no way how to correctly distinguish bind mounts, since kernel does...

> Recategorising as an enhancement request to offer a way for users to decide for themselves which set of risks they want to tolerate (`pip-compile` stopped pinning `pip` and `setuptools`...