Fridolín Pokorný

Results 197 comments of Fridolín Pokorný

We can provide our bot [called Kebechet](https://github.com/thoth-station/kebechet/). It can manage releases and generate a changelog using an ML model automatically. It's already [available on GitHub](https://github.com/apps/khebhut) and it operates on (more...

@GreyZmeem friendly ping, is this something to consider in the implementation

> Isn't `setuptools` already in `build_system.requires` (line 4)? That is a requirement for build system to build a package out of sources. This PR adds runtime dependency that needs to...

Thanks for suggestions. Adjusted to use packaging in the most recent version.

Yesterday, we had a review session with @yzhan289 (thanks for it!). Andrew raised the following comments (please add more if I missed something): - we should merge 'e2e_tests' directory with...

> @fridex title contains "[WIP]" but PR is not in "draft" state, is this PR ready for review? Adjusted, now no longer WIP. :+1: Just wanted to have this more...

Ah, sorry. I thought this is another PR -- this one is still WIP.

Python3.8 tests are green. Python 2.7 tests report the following error on my machine: > ImportError('../.tox/py27/lib64/python2.7/site-packages/cryptography/hazmat/bindings/_openssl.so: undefined symbol: ERR_GET_FUNC,) It looks like there are issues with FIPS symbols in OpenSSL...

Rebased and squashed. Ready for a review (tests might take some time to finish but they were already reported as green in the previous run).

> Any suggestions? It looks like the environment is not properly set up - hence issues with tenacity and with pytest. The README states procedure to install dependencies: pip install...