Francesco Calicchio

Results 29 comments of Francesco Calicchio

> Given we don't have a unified way of formatting code, it would be helpful if any change that is formatting was discarded before pushing the commit, this would make...

TBH I'd never ever used `go_router`, so maybe I am wrong, but why in the world this is needed: ```dart @immutable class HomeScreenRoute extends GoRouteData { @override Widget build(BuildContext context,...

seems a good idea! But I think we first have to fix a lot of stuffs on the code side...theming mostly. Currently the theming system is broken and doesn't follows...

I'll do the iOS tests and review the PR by the end of the day 👍

> If you have a chance to test it on iOS, that would be helpful. Jus tested on iOS, it works fine, good job 👍 > Regarding the automatic theme...

>Querying using [MediaQuery.of](https://api.flutter.dev/flutter/widgets/MediaQuery/of.html) will cause your widget to rebuild automatically whenever any field of the [MediaQueryData](https://api.flutter.dev/flutter/widgets/MediaQueryData-class.html) changes (e.g., if the user rotates their device). Therefore, unless you are concerned with...

Thanks for the confirmation @bongio94 About the font styling, I usually find it easy and consistent to stick with the [Material Typography Guidelines](https://m3.material.io/styles/typography/type-scale-tokens). Btw, this seems a bit out of...

Seems really cool, I never managed to do something like that...do you have some resources on that?

@lucaantonelli Seems LGTM to me 👍 Good job ;)