sossoldi Resolve #292 - Enhance theme management with system theme support

In reference to issue #292

Could someone please assist with testing this on iOS? I'm unable to test today.

It could be appropriate to involve an approval from the UI/UX team for this specific implementation.

Mar 18 '25 18:03 xDefcon

I'll do the iOS tests and review the PR by the end of the day 👍

Mar 19 '25 10:03 fres-sudo

@fres-sudo Thank you for the precious feedback! I've made changes to improve the code structure and state management as suggested. If you have a chance to test it on iOS, that would be helpful.

Regarding the automatic theme icon, maybe we should get some input from the Design team?

Mar 20 '25 00:03 xDefcon

If you have a chance to test it on iOS, that would be helpful.

Jus tested on iOS, it works fine, good job 👍

Regarding the automatic theme icon, maybe we should get some input from the Design team?

Agree, but since maybe it's more complex for them to run the PR locally, I leave here some ideas:

This was the original one chosen by @xDefcon :

Let's wait for @federicopozzato 's feedback!

P.S. for a bit of context, this will be the icon that indicates to the user that he's currently using the default theme of his phone

Mar 20 '25 08:03 fres-sudo

Since now it will be a 3 status switch (light-dark-system default), and no more a 2 status, how will it behave?

In this case it's a dropdown is more appropriate. Since this element is not yet present in the app, I suggest to leave this PR open until we design this behaviour.

Thanks for reaching out to me!

Mar 20 '25 13:03 federicopozzato

I often see this kind of theme switcher.

Just an idea 🙂

Screenshot_1742544736

Mar 21 '25 08:03 bongio94

@bongio94 I like it! Let's go for it. Just follow the design style for this kind of element that is already implemented for the notification part: https://www.figma.com/design/6NyY9yqunpbU7HIkbNEAL3/Sossoldi-App?node-id=3286-9189&t=5wYGZcAdXnVsZBaa-11

Mar 21 '25 08:03 federicopozzato

Oh there's some guidance already, sorry I didn't look at the Figma before making the example 👍

Is it okay for you @xDefcon to add these changes?

Mar 21 '25 08:03 bongio94

@bongio94 I'll work on it this weekend. Thanks for the feedback.

Mar 27 '25 17:03 xDefcon

@bongio94 I think I should wait for #360 to be merged first, do you have any ETA?

Mar 27 '25 17:03 xDefcon

Hey @xDefcon

I don't tbh. I've asked if I can move forward with the design/behaviour I proposed

Mar 27 '25 20:03 bongio94

@bongio94 Answered on #356 Proceed with the solution on the #356 issue

Mar 27 '25 20:03 federicopozzato

Hi @xDefcon👋 We recently merged a PR that changed the folder structure, which caused some conflicts here. When you get a chance, could you take a look and resolve them?

If there’s no response in the next 15 days, we’ll consider this PR inactive and plan to close it to keep things tidy.

Thanks!

Aug 02 '25 10:08 theperu