Lukasz Mlodzik

Results 13 comments of Lukasz Mlodzik

I found https://github.com/NetSweet/netsuite/pull/405 this PR which imo is better solution. We could add there support for invalid account creds there. @iloveitaly what do you think?

@iloveitaly I am fine with closing my PR, #405 is open since 2018 and mine is since 2019 and problem is causing a lot of problems for us and for...

Hey @iloveitaly , could you comment or merge this PR? I have similar issue and I think more people are affected by this..

@iloveitaly thanks! we could add feature flag, so it would not break old implementations.

> Feature flag is probably a good idea as this might cause unexpected exceptions for people using this gem. I'm happy to implement the flag! > > One option is...

Thanks @aom this looks awesome! Ideally this option should be a default one, but it is a breaking change. It could be released under `v 1.X` version in the future....

@iloveitaly you commented [here](https://github.com/NetSweet/netsuite/pull/405#issuecomment-460828018) about `unintended side effects`, so we thought it can be turn on in the configuration.. Maybe we can do it other way round ? Turn it...

@iloveitaly any updates on this PR? Can we merge it?

Bump! Guys would like to use this feature and I don't want to use fork. Can we merge it? @iloveitaly