freescout icon indicating copy to clipboard operation
freescout copied to clipboard

closedByUser is not set in DB if the conversation is closed at the beginning

Open fulldecent opened this issue 4 years ago • 7 comments

I purchased the API/Webhooks module.

Test case

  1. Support agent logs in
  2. Support agent clicks conversation button
  3. In this conversation the status is marked as closed
  4. Click send

Expected outcome

The closedByUser in API is set to that person.

Actual outcome

closedByUser is null.

fulldecent avatar Oct 11 '21 17:10 fulldecent

We can't reproduce the issue. Could you please attach screenshots or video of steps 1-4 and API output.

freescout-helpdesk avatar Oct 13 '21 07:10 freescout-helpdesk

Yes, please find below one example where the conversation is closed but there is no closedBy:

Screen Shot 2021-10-13 at 11 32 36 Screen Shot 2021-10-13 at 11 32 33

fulldecent avatar Oct 13 '21 15:10 fulldecent

Are you using the latest version of FreeScout and modules? Can you reproduce the issue on demo.freescout.net?

freescout-helpdesk avatar Oct 13 '21 17:10 freescout-helpdesk

Yes.

I have just reproduced it on demo website.

Screen Shot 2021-10-13 at 16 02 00 Screen Shot 2021-10-13 at 16 02 02

Perhaps the error is here:

https://github.com/freescout-helpdesk/freescout/blob/078e098b28266ee5b7f2cd775a5b4e5aad6df48e/app/Conversation.php#L1881

It is missing something like this:

https://github.com/freescout-helpdesk/freescout/blob/078e098b28266ee5b7f2cd775a5b4e5aad6df48e/app/Conversation.php#L559

fulldecent avatar Oct 13 '21 20:10 fulldecent

How are you creating the conversation?

2021-10-14_07-56-49

https://demo.freescout.net/api/conversations/16?api_key=c2ba609c687a3425402b9d881e5075db 2021-10-14_07-58-43

freescout-helpdesk avatar Oct 14 '21 04:10 freescout-helpdesk

Yes that's what I did with status closed

fulldecent avatar Oct 14 '21 11:10 fulldecent

We'll leave it as help wanted. Maybe someone will be able to reproduce it and find the reason of the issue.

freescout-helpdesk avatar Oct 15 '21 06:10 freescout-helpdesk

I have reproduced this on demo just now. Status is closed but closed by is null.

Did it twice in a row and got different results.

Closing this issue. If somebody is better at testing than me they can reopen it!

Screen Shot 2022-10-12 at 14 06 15 Screen Shot 2022-10-12 at 14 06 07

fulldecent avatar Oct 12 '22 18:10 fulldecent