Fred Wu

Results 39 comments of Fred Wu

This is a great feature to have! Though as it stands it breaks the build, and please add some tests to cover this new feature too. :)

Nice! Could you please update the code to use hash rockets so that it passes Travis's ruby 1.8.7 build? Thanks! :)

Hi @robbjl thank you so much for the PR! Sorry I haven't had a chance to review this for such a long time. Is your app still on rails 3.1?...

Very nice, thanks for this! :) Before I merge this in though would you add some tests please?

As soon as tests are added I'll merge this in. :) cc @ivobenedito

Hi @ivobenedito do you reckon you'd have time to write some tests for this? :)

For now you'd have to define it and supply an empty hash for it to work. I might add custom form in the future, but for now this work around...

> but it should be trivial to try get first instead of as a rescue for create! I think Sure! I don't have a strong opinion on this one so...

Thanks @antonmi ! Given how useful those helpers are, any chance of having them packaged in an official `espec_phoenix_helpers` package? ;)