Yanfei Lei

Results 29 comments of Yanfei Lei

@Lid0 请问是怎么解决的呢 我也遇到了这个问题

Hi weather319,I also want to use HiExpan in Chinese corpus, but the porbase which HiExpand used to extract features does not suit Chinese, would you like to share which Chinese...

@Shenjiaqi Thanks for this PR, LGTM. Could you please add the ticket id and module name `[FLINK-29347] [runtime]` to the commit message? @Myasuka Would you like to take a look?

Thanks for creating this PR @JesseAtSZ. IIUC, you expect an IOException when the checkpoint directory exists(`fileSystem.mkdir()` return `false`)? I think it's a little wired, could you please explain your motivation?

@JesseAtSZ Thanks for your explanation, `fileSystem.mkdirs()` not only returns `false` when the directory exists, but also returns `false` when there is no permission to write. This PR makes sense to...

Hi @Myasuka, this test has always been unstable due to the way we obtained checkpoints, I refactored it. Could you please take a look?

Thanks a lot for reviewing. > I still not get the idea why the test is unstable. Could you describe it more clearly? According to the stack trace in[ FLINK-27162](https://issues.apache.org/jira/browse/FLINK-27162)...

Thanks a lot for reviewing, squashed. > do we also need to cherry pick the changes to release-1.15 branch? No, from [FLINK-21321](https://issues.apache.org/jira/browse/FLINK-21321), this test(1bf45b25791cc3fad8b7d0d863caa9b0eef9a87b) was only merged into master.