Frederik Bosch

Results 110 comments of Frederik Bosch
trafficstars

I doubt whether that is related to the PR

Great work @jameswilddev and @gmponos (!). To what extend is the exponential parser also able to parse normal numbers?

No objections. Looks good! It should be tested though. I am planning some major work for this library in the near future. I will include `Teller` then. If someone wants...

@gmponos Why not inject a Decimal parser and then delegate the parsing process once you have handled the exponential part? Maybe I should have a closer look, but as it...

@gmponos Could you update this PR against the latest master? Sorry for our very late action on this.

I don't know if this should be part of this library. For now I tagged it for milestone 4.1.0. We will decide then to merge this or not. Thank you...

> recommend rewiring them to the real method with throws doc block. How would that look like?

Few considerations before continuing: 1. Is this the right path to start with? 2. What to do with the PHP Calculator? It will have strange results when multiplying and dividing,...

@m4tthumphrey You can already do that. ```php new Money(11535, new Currency('GBP')); new Money(4251, new Currency('GBP')); ``` You should implement your own currency with subunits set to 4. See the [BitcoinCurrencies](https://github.com/moneyphp/money/blob/master/src/Currencies/BitcoinCurrencies.php)...