Frederik Bosch

Results 110 comments of Frederik Bosch
trafficstars

@michaelklishin @dumbbell In PR #13194 I have made a proposal how to fix this bug. I'd like to have your feedback before continuing. Would you be so kind to let...

If you do no want any `new URL()` modification, untap what the `URLPlugin` has hooked. ```js class RemoveURLPlugin { apply(compiler) { compiler.hooks.afterResolvers.tap("RemoveURLPlugin", (resolveOptions) => { compiler.hooks.compilation.taps = compiler.hooks.compilation.taps.filter( (tap) =>...

@harikt and @koriym, move this one in?

Thanks for the effort @srjlewis. I might have advocated my points strongly but I really appreciate the work.

With driver specific subclasses in PHP, I think we should re-evaluate more than just the new `PDO::connect` method. Driver-specific classes are available in this library since #138 was merged. To...

1. Why keep the compatibility if you go to a version 6? People can use v5 for compatibility? 2. That's because it's an example, not a PR. I would leave...

I disagree with that. 1. Why rush to release before 8.4? 2. There is no composer magic needed: if your are on PHP < 8.3, you use version 5 of...

@koriym I don´t get your suggested approach completely. Could you elaborate what you want to do in v5? What do we gain with this new `establishConnection()` method? As stated before,...

I would do the latter and on-top I really believe we need to investigate how our parsers. What use do they still have?

Look at [this commit in php-src](https://github.com/php/php-src/commit/715b9aaa09e1ad76a94f32b17da7927592fdae0a), that is pretty much what we are offering with our parsers.