Frédéric Delaporte

Results 190 comments of Frédéric Delaporte

Switched to WIP: since 5.2 has been released, this PR has now binary breaking changes.

Do we actually need to disable that block for running NHibernate on .Net 5? I think it is not even needed. The application will run just fine provided it does...

@gokhanabatay, this is not a NHibernate issue but a cache question, you should have opened your case [there](https://github.com/nhibernate/NHibernate-Caches). But anyway binary serialization is only a default method of serialization for...

@oyzar > the usages in NHibernate should still be changed. Why? Can you elaborate on this? `SerializableType` is meant to binary serialize, there is no point in "changing" it. No...

There are not any such implementations, as you could infer by reading your link. The recommended alternatives are serialization to XML or JSON, neither of which are a binary serialization....

And what about the read-write case, which will fail on its disposed lock? It is no better than a NRE and we should also handle this case more gracefully, don't...

Yes I dislike too this bloat code for checking the object state everywhere. But there is also the `_asyncReaderWriterLock` which can be disposed and so needs to be protected by...

I thought you wanted me to put something in the `CacheBase` class, but instead you refer to the `CacheBase` typed property versus the `ICache` one. One trouble is, currently, the...

As commented before doing it: - To avoid a possible breaking change in a SemVer patch release. Changing one of the existing property for throwing when the cache is null,...

I have added a commit to remove `InternalCache` property. But as explained, it adds some other kind of bloat code, in order to be able to call the explicitly implemented...