Frédéric Delaporte

Results 172 comments of Frédéric Delaporte

This really looks to me like a trouble not bound to NHibernate. See [this post on MSDN](https://social.msdn.microsoft.com/forums/en-US/6afa7c42-8286-48e8-b3fd-be5de574b611/transactionscope-adonet-and-timeouts) (requires a Microsoft account). It seems to be the exact same trouble, but...

On GitHub action, AFAIK we are running SQL Server under Linux, and we seem to hit dotnet/SqlClient#109. It has been fixed in Microsoft.Data.SqlClient 2.0, but we are using System.Data.SqlClient, which...

@hazzik, it seems this cancel test freezes Oracle test suit. (Maybe Oracle does not support Cancel...) The NHibernate agent on TeamCity seems gone. Can you check what is going on...

It makes for a central point for checking database limitations, which may help when we wish to check if some of these limitations do no more apply. Tests skipped directly...

Here is a series of fix proposals addressing my review comments.

While looking into this, I have spotted a number of cases which will not play nice with dependency injection, due to not using the service provider, or forcing a default...

@hazzik, do you agree for merging or do you wish to have another look yourself before?

Postponing this to 5.3 is quite unfortunate. This PR changes public interfaces which were not yet released. Delaying it will cause more breaking changes to dodge, and more members to...

I am talking about "interface" in its broad meaning, not just the technical C# `interface`: - Removal of class `HibernateObjectsFactoryException`. - Removal of setting `objects-factory`, replaced by `service-provider`. - Removal...

I do not see it as going into an opposite direction. For me, it is instead the same direction: removing specificities hindering dependency injection. I do neither see where is...