Dan Wallis

Results 98 issues of Dan Wallis

## Proposed Changes While looking into changing the coding standard used for PHP_CodeSniffer itself, I noticed that this plug-in doesn't currently work in that scenario. This pull request allows this...

triage

When HTML is used as part of a `.phtml` file, it should be subject to the same rules as HTML used in a `.html` file. The additional test files here...

partners-contribution
Progress: ready for review
Partner: Youwe

The installation instructions for this coding standard are unnecessarily complex. Composer plugins are capable of performing the necessary registration automatically, without requiring the user to manually set up (or alter)...

partners-contribution
Progress: review
Partner: Fisheye

While reviewing the Static Test failures in https://github.com/magento/magento2/pull/36976 (which are out of scope for the intended change), I noticed that the message required for a `@deprecated` tag does not support...

partners-contribution
Progress: approved
Partner: Fisheye

These files are only useful when working directly on this standard, and not when consuming the standard. When installing this standard via Composer, these files can safely be excluded. Closes...

partners-contribution
Progress: approved
Partner: Youwe

https://github.com/magento/magento-coding-standard/commit/9c2ac84d1fddfbc1f5c16762d42280d1b7ffaeb9 is the main purpose of this pull request. In order to get there cleanly, a number of refactoring commits were required. I recommend that this pull request is reviewed...

partners-contribution
Progress: approved
Partner: Youwe

partners-contribution
Progress: approved
Partner: Youwe

partners-contribution
Progress: approved
Partner: Youwe

partners-contribution
Progress: approved
Partner: Youwe

Fixes https://github.com/magento/magento-coding-standard/issues/434

partners-contribution
Progress: approved
Partner: Youwe