Fraser Cormack
Fraser Cormack
> Could you please add a CodeGen lit test to exercise the changes in NVPTX.cpp? Sorry, do you mean a backend CodeGen LIT test, or a frontend CodeGen test? There...
> Could you please add a CodeGen lit test to exercise the changes in NVPTX.cpp? Note the updated version of this patch doesn't touch `clang` any more once #14634 landed.
ping @intel/dpcpp-spirv-reviewers, thanks
ping @intel/dpcpp-spirv-reviewers
Three E2E tests failing on linux: ``` Failed Tests (3): SYCL :: DeviceDependencies/free_function_kernels.cpp SYCL :: LLVMIntrinsicLowering/bitreverse.cpp SYCL :: LLVMIntrinsicLowering/sub_byte_bitreverse.cpp ``` All for the same reason: ``` clang++: error: option '-fno-sycl-allow-device-dependencies'...
Same on Windows: ``` ******************** Failed Tests (2): SYCL :: DeviceDependencies/free_function_kernels.cpp SYCL :: LLVMIntrinsicLowering/bitreverse.cpp ```
@intel/llvm-gatekeepers this is ready to merge, thanks. The failures are unrelated (see above).
> Oh, and the cherry picked commit is not by the present author, so unless that author joined this project and created that merge request, the authorship will be incorrect....
@intel/llvm-gatekeepers this looks good to merge, thank you!
Apologies, I meant to ask this over in OpenCL-Docs