intel
[SYCL][NVPTX] Emit 'grid_constant' annotations for by-val kernel params
Also fix up the DeadArgumentElimination passes to correctly preserve the
annotations; when removing arguments from functions, dead parameters
need pruned and alive ones may need their values shifted down by the
number of dead arguments that came before them.
NOTE TO REVIEWERS this PR includes a cherry-pick of a recent upstream commit which has not yet been pulled down. Without it, the NVPTX backend crashes when processing this new type of annotation. If this is merged before this cherry-pick is pulled down, it would be best to leave it unsquashed. Otherwise we can drop it from the PR.
NOTE TO REVIEWERS this PR includes a cherry-pick of a recent upstream commit which has not yet been pulled down. Without it, the NVPTX backend crashes when processing this new type of annotation. If this is merged before this cherry-pick is pulled down, it would be best to leave it unsquashed. Otherwise we can drop it from the PR.
The commits will be squashed. If you don't want to wait for a pulldown, I recommend opening a separate PR with cherry-pick only.
NOTE TO REVIEWERS this PR includes a cherry-pick of a recent upstream commit which has not yet been pulled down. Without it, the NVPTX backend crashes when processing this new type of annotation. If this is merged before this cherry-pick is pulled down, it would be best to leave it unsquashed. Otherwise we can drop it from the PR.
The commits will be squashed. If you don't want to wait for a pulldown, I recommend opening a separate PR with cherry-pick only.
Seems like a massive waste of time to work around a bad policy.
Oh, and the cherry picked commit is not by the present author, so unless that author joined this project and created that merge request, the authorship will be incorrect.
I think it's best we maintain correct attribution of copyrights
@premanandrao can you take a look at this? I am off till Wednesday.
Oh, and the cherry picked commit is not by the present author, so unless that author joined this project and created that merge request, the authorship will be incorrect.
I think it's best we maintain correct attribution of copyrights
Yes it doesn't seem like the current system can correctly support cherry-picks in PRs without manual intervention.
Either way, the commit we depend on has been merged as part of the pulldown, so this PR is unblocked in that regard.