Frank McSherry

Eh, it's a bit hard to comment without knowing the folks. My initial inclination was to go vicious, but I got that under control. ;) Generally, the more you need...

It is just about the re-use of memory, yes. And Rust is picky about the memory being owned, and being typed. In this case it was interesting to me that...

Oops. Fixing now!

Should be good to go now.

Aahh, oops! It was an early preview; I hope the lack of care and detail wasn't criminal. :)

Feel free to borrow as much as you can. This was one of my first Rust projects, and I'm pretty sure there is lots to improve. For another approach, there...

I'm not certain I understand the distinction between a `Drop` implementation that uses `mem::forget` to prevent the `Drop` implementations of its members, vs wrapping the members in `ManuallyDrop`. I have...

So, quick thoughts: This isn't how I was expecting you would use `ManuallyDrop`! It's not that it's wrong, but for some reason I was expecting something slightly different, and I...

Some mechanical comments about the PR; 1. I'll need to add a `CONTRIBUTING.md` before landing, and 2. There are several unrelated `cargo fmt` changes; it doesn't agree with my laptop's...

It is reasonable that things should get faster as various parts improve. In the past four years, your laptop, Rust's toolchain, and Linux have all probably gotten better. At the...