Frank Male

this *would* be really nice

Thank you for your suggested improvement. You are right, this is not currently implemented: https://github.com/frank1010111/pywaterflood/blob/6460d6275bdd81923db94a2ff17b8080eaa543ea/python/pywaterflood/crm.py#L633-L635 The python constrained optimization options provided by scipy.optimize tend to be very slow when handling...

Oh yes, I have done it before in this branch: https://github.com/frank1010111/pywaterflood/tree/jax which is a few years stale. I would have to think about how to refresh the branch given how...

The code to generate that plot was ``` fig, ax = plt.subplots(figsize=(8, 5)) ax.set_title(s) for i, row in locdata.iterrows(): color = "forestgreen" if row["SYM"] == "OIL" else "xkcd:plum" ax.annotate(i, (row["SURFX...

## Package Review *Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide* - [x]...

I appreciate it. If you want me to review the dev branch, I'm okay doing that. Whatever works best for you is good for me.

Today, I checked the paper draft [created by a github action](https://github.com/dodge-research-group/thztools/actions/runs/11310914645/artifacts/2049501236) and found it meets JOSS specifications.

I've got to say, your documentation is beautifully organized.

A nit for your documentation is that you've got docstrings for the parameters of your dataclasses, but Sphinx expects docstrings for your attributes. For instance, the lines [here in NoiseModel](https://github.com/dodge-research-group/thztools/blob/74945426ddd1ffe617ce7edceef18b4da3a4491e/src/thztools/thztools.py#L211-L223)...

To synthesize some of the discussion on the SWUNG Mattermost, dask is a heavy dependency for little perceived gain, but polars might be an option.