Francisco Giordano comments

Results 844 comments of


                                            Francisco Giordano

Solidity 0.8.4 Custom Errors

Fixed in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4261.

Meta Issue: Planned breaking changes for new major (5.0)

Most of these items have their own issues by now so I will close this issue. The missing ones are: - Make some contract libraries (ERC1967) We can't make `ERC1967Upgrade`...

ERC20 simplification with allowing _transfer() to perform _mint() and _burn() functionalities

This has been implemented in `next-v5.0` in #3838 and #3921.

Enable `supportsInterface(...)` from ERC165 on ERC20 contract implementation

I would add that an ERC being Final shouldn't be interpreted as it being safe, in general for any ERC. --- Closing this issue for the reasons explained in https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3575#issuecomment-1193764676.

Consider removing non-standard requirement in ERC721.approve

Yes thank you. I think this was fixed in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4377.

Allow Counter increment by more than just 1

Counters are being removed in 5.0.

Make ERC20Votes independent of ERC20Permit

Fixed by https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3816 for future 5.0 release.

ERC721 extension for minting token batches

> Is ERC721Consecutive.sol only used in contract creation? Yes. Batch minting reverts when used outside of the constructor. Furthermore, this has already been released. Please see the code or [the...

ERC1155Supply: Add totalSupply() function that returns overall supply count

In any case this will never be included by default so users can make an informed decision if they decide to use this functionality with what it entails. I had...

ERC1155Supply: Add totalSupply() function that returns overall supply count

We're with you, making a library without footguns is definitely part of our design philosophy, but at some point we need to treat users like adults too. :sweat_smile: In this...