Francisco Giordano

This is an interesting case for keeping the checks against non-zero addresses in the code. It's definitely an easy mistake for devs to directly pass the result of `ecrecover` to...

This sounds useful. Can you share some of the use cases you have in mind? Is the linked function exactly what you're looking for or is there something you would...

@Amxx Is this the same as https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3617? Or is that necessarily for storage, whereas this issue could refer to building a root in memory?

Found some things I still need to fix for parity with the current site.

Ok this seems to be at parity now, will go ahead and merge.

This is a duplicate of https://github.com/OpenZeppelin/openzeppelin-contracts/issues/2402 (closed). See https://github.com/OpenZeppelin/openzeppelin-contracts/issues/2402#issuecomment-780877304, although it has been summarized by @Amxx above. Is it possible for you to inherit `ProxyAdmin` and use `transferOwnership` in the...

Is this something we should do on a 5.0 release? Do we have other constructors that use `msg.sender`, and if so should we change them all to use an argument?

Yes, it can be worked around, but we should also see from a security and good defaults angle, like https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3720.

There is also another option, though it's arguable a "non-solution": leaving `totalAssets` unimplemented and have users implement it to their needs. I've argued before that most vaults will need a...

The problem is that the default should be risk-minimized... If we want to make it optional, the default should be abstract.