Francisco Giordano
Francisco Giordano
CodeSpell is a great idea but it's highlighting errors in unrelated files. **Edit:** Ok they show up in the Files tab but they are not affecting the mergeability of the...
The remaining external links are for test cases and reference implementation. Are those ok? The discussions link is the GitHub issue, back in June it was said that it's not...
> For your convenience, I put them in the assets folder myself. Thanks. I added some missing files that are relevant to fully specify the reference behavior, as well as...
I've proposed the title "EIP-20 Permit Extension: Signed Approvals", and edited the description to mention EIP-712 there.
@Pandapip1 MrChico approved the PR yesterday and the only changes afterwards were fixes to broken links so the approval is still valid IMO.
If it is possible to make an exception, given that this PR requires a manual merge anyway, I think we would appreciate that so this EIP doesn't suffer more delays....
@Pandapip1 Can you confirm if this will be manually merged or is still pending a review?
Just to be the clear the author has already given [an approval](https://github.com/ethereum/EIPs/pull/5506#pullrequestreview-1087683872) and the only thing that changed since then was that we fixed two links to assets that were...
I am trying to reach @MrChico to get this moving, and asking about getting set up as author as well. I've pushed the deadline until October 1st hoping that is...
FYI I haven't received a reply yet.