obsidian-list-modified icon indicating copy to clipboard operation
obsidian-list-modified copied to clipboard

Remove comma at the end when checking ignore

Open Benature opened this issue 11 months ago • 1 comments

Thanks for the great plugin!

One time I added a comma accidentally and found it failed to track files' modification, as there is an empty string "" in excludedFolderPaths. Therefore, I add the code to remove the comma at the end for folder/tag/text.

Benature avatar Mar 04 '24 10:03 Benature

Thank you for this. Sorry for the long wait. This looks good, but I am going to merge this into the dev branch "jest" (where I am adding unit tests and refactoring the plugin) once that is complete. I have been busy lately so I am not sure when this would be completed

franciskafieh avatar Apr 19 '24 17:04 franciskafieh

Thank you again. For the sake of recognizing your contribution, I have merged this into master.

After your bug find, I have realized that the regex used is unintuitive and difficult to maintain. Instead, the rewrite now uses plain JS functions. See https://github.com/franciskafieh/obsidian-list-modified/blob/jest/src/utils/converCommaListToArray.ts and its related passing test https://github.com/franciskafieh/obsidian-list-modified/blob/jest/tests/utils/convertCommaListToArray.test.ts

franciskafieh avatar Jun 25 '24 02:06 franciskafieh