Francesco Bonacci
Francesco Bonacci
Proposed API change lined up for `AddCheck`, `AddAsyncCheck`, `AddCheck`, `AddTypeActivatedCheck` in _HealthChecksBuilderDelegateExtensions.cs_ and _HealthChecksBuilderAddCheckExtensions.cs_
Renaming from `AddIndividualCheck` to `AddCheck` will cause an ambiguous reference as we will end up with two public APIs conflicting on the optional params. This is unless we don't want...
Summarizing the open points from this PR:
### AddCheck Naming: - Renaming of `AddTypeActivatedCheck` due to source breaking with params object[] tags: users might have passed a TimeSpan as params. - Renaming of `AddCheck`, `AddAsyncCheck `due to...
### Predicate Injection: With the adopted design, individual HCs cannot use the predicate param passed in the `CheckHealthAsync` to filter out HCs that should not be run – individual HCs...
### Cancellation: For the same reason above, cancellation parameter passed in the `CheckHealthAsync` has no effect on the individual HCs, since they run isolated from the publisher.
### Default values for Period and Delay: `HealthCheckRegistration` sets the default values for Delay and Period to `Timeout.InfiniteTimeSpan` and `TimeSpan.Zero` (`default(TimeSpan)`). `DefaultHealthCheckService` follows the same convention when deciding whether an...
### Migration to ValueTask: Updating the `AddAsyncIndividualCheck` APIs to `ValueTask` will force us to update also its dependencies on `DelegateHealthCheck` with a cctor accepting `Func`. This would require some work...
> ### AddCheck Naming: > * Renaming of `AddTypeActivatedCheck` due to source breaking with params object[] tags: users might have passed a TimeSpan as params. > * Renaming of `AddCheck`,...