Felipe Vogel
Felipe Vogel
I found that CommonMarker is turning those repeated hyphens into dashes, before the user mention is turned into a link. #1039 adds: - A preliminary step of escaping the hyphens,...
Thanks @pushcx for the feedback. I see what you mean about the risks of escaping and unescaping data. And thanks for pointing out that other edge case—I've incorporated it into...
@pushcx Brilliant! I really wasn't comfortable with how I was changing the nodes _at the same time_ that I was detecting whether they needed to be changed, but I guess...
I made a PR following the above suggestions: #1056 On further reflection, though, I don't think this is better than my original approach of escaping and unescaping hyphens and underscores...
I looked into this, and it seems that at least one subclass of `Liquid::Block` will need to be added within `Bridgetown::Tags`, maybe two: one for `ruby_render`, another for `slot`. What...
Gotcha, so a Liquid tag (not a block as above) would be OK for an MVP? Like this: ```liquid {% ruby_render "my_component", title: "My Title" %} ```
How about this? ``` {% ruby_render MyComponent.new(title: "My Title") %} ``` Just let me know which is preferable. I just realized that the content inside a Liquid tag doesn't have...
@jaredcwhite I intend to add one more commit to [my PR](https://github.com/bridgetownrb/bridgetown/pull/1055) adding a docs section to the site (analogous to [the section on liquid_render](https://www.bridgetownrb.com/docs/components/liquid#rendering-liquid-components-from-ruby-based-templates)), but the implementation is there if...
I've just started looking into this, and maybe I can answer my own question as I go along, but I'm wondering about this bit from the Issue description: > tested...
@jaredcwhite Outside this PR @anantone and I have been corresponding about this. I suggested this issue to him as a good first issue, and he did a great job investigating...