Filip Petkovski

I see, that maybe should not have gotten through. We should use `apiVersion` instead to be consistent with the kubernetes API. Since this feature is experimental, we should be able...

One thing I am still not following, if we have a GVK, why do we need a subsystem/apiversion as well? Isn't this information already contained in the GVK?

Got it, thanks for the explanation. In that case, this field seems to be related to the of the metric, and not to the kube api resource itself. From what...

/lgtm

This looks good, we just need you to sign the CLA. You can do this with ``` git commit --amend --no-edit --signoff ```

It seems that this was a breaking change introduced in KSM 2 but it was not well documented in the changelog. From what I can see, KSM 1.9 adds all...

@mindw that seems like a good summary to me :+1:

This would imply some sort of a config file that KSM would watch or reload based on an http request. I am not sure if the complexity of maintaining it...

There is a similar discussion here: https://github.com/kubernetes/kube-state-metrics/pull/1710#discussion_r886082800 The questions with having a config file are: * How will KSM know when to reload the config * Which options should be...

I might be missing something, but isn't this an example of a made up CRD?