kube-state-metrics icon indicating copy to clipboard operation
kube-state-metrics copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Add support for rolebindings

Open kaitoii11 opened this issue 3 years ago • 3 comments

What this PR does / why we need it: Adds support for generating metrics for clusterrolebindings and rolebindings

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1717

kaitoii11 avatar Aug 06 '22 15:08 kaitoii11

/lgtm

/hold for @dgrisonnet and @fpetkovski to review.

mrueg avatar Aug 10 '22 09:08 mrueg

/lgtm

fpetkovski avatar Aug 10 '22 09:08 fpetkovski

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fpetkovski, kaitoii11, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [fpetkovski,mrueg]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 10 '22 09:08 k8s-ci-robot

/hold cancel

mrueg avatar Aug 18 '22 19:08 mrueg

Thanks a lot for your contribution!

mrueg avatar Aug 18 '22 19:08 mrueg